Skip to content

Cibuild built from sdist -> wheel #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 12, 2025

Conversation

cvanelteren
Copy link
Contributor

This PR achieves two things.
First it builds the wheels directly from sdist rather than building the two separately.
Second, it ensures that cibuild will use the data and data_hires in the builds.

This was discussed on #611.

@cvanelteren cvanelteren mentioned this pull request Feb 26, 2025
@cvanelteren
Copy link
Contributor Author

kind nudge @molinav

@cvanelteren
Copy link
Contributor Author

Hi @molinav does this align with your intention?

@molinav
Copy link
Member

molinav commented Jun 12, 2025

For the record: this seems to be the only way right as of today (12 June 2025) to create wheels from sdists using cibuildwheel.

It is possible to set the environment variable CIBW_BUILD_FRONTEND to either "build" or "pip" (see here), but:

  • "pip" delegates to python -m pip wheel.
  • "build" delegates to python -m build --wheel. If this command were python -m build, this would create the wheel from the sdist (since build 0.5.0), but the --wheel switch changes the behaviour of python -m build and creates the wheel directly from the given input folder.

In the job building the data packages, I have changed the call python -m build --sdist --wheel to python -m build. The latter guarantees that the wheels are build from the sdists, the first one builds sdists and wheels separately.

@molinav molinav force-pushed the cibuild-built-from-sdist branch from aada2c9 to 2e196f5 Compare June 12, 2025 17:04
@molinav
Copy link
Member

molinav commented Jun 12, 2025

I am merging this once the last round of pipelines succeed (it should). Then I will move to the docs PR and resolve the conflicts created by my changes here (the docs PR also includes changes from this PR).

@molinav molinav merged commit 4e5251e into matplotlib:develop Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants